feat: Add impl From<http::HeaderName> for Vary#210
Merged
seanmonstar merged 1 commit intohyperium:masterfrom May 27, 2025
Merged
feat: Add impl From<http::HeaderName> for Vary#210seanmonstar merged 1 commit intohyperium:masterfrom
impl From<http::HeaderName> for Vary#210seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
seanmonstar
approved these changes
May 27, 2025
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Seems like a good idea, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like a good start since one of
Vary's common forms is a list ofHeaderNamesI went with this as the relatively non-controversial impl, but I think it would be nice if there was a
FromIterator<HeaderName> for Varyimpl as well (which I'd be happy to add if that sounds reasonable)